Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google_mobile_ads.yaml to use java 17 #930

Closed
wants to merge 13 commits into from

Conversation

LTPhantom
Copy link
Collaborator

@LTPhantom LTPhantom commented Oct 9, 2023

Description

In preparation for updating the gradle plugin used by the android this PR updates the java version used by the setup-java action to java 17

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

In preparation for updating the gradle plugin used by the android side.
@LTPhantom LTPhantom requested review from jjliu15 and removed request for jjliu15 October 9, 2023 15:29
@LTPhantom LTPhantom closed this Oct 18, 2023
@LTPhantom LTPhantom deleted the LTPhantom-patch-to-java17 branch December 1, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant